Skip to content

fix(chat): fix to stop bash executions for stop button #7100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 19, 2025
Merged

fix(chat): fix to stop bash executions for stop button #7100

merged 11 commits into from
Apr 19, 2025

Conversation

@ashishrp-aws
Copy link
Contributor

@ashishrp-aws ashishrp-aws commented Apr 18, 2025

Problem

Long running ExecuteBash commands keep running after clicking on stop button.

Solution

  • Added force Stop to kill bash executions
  • Added tabTotrigger Id mapping to maintain trigger Id consistency across agentic loop.
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested review from a team as code owners April 18, 2025 01:14
@github-actions
Copy link

github-actions bot commented Apr 18, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@zixlin7 zixlin7 merged commit a597cd2 into aws:feature/agentic-chat Apr 19, 2025
20 of 22 checks passed
@ashishrp-aws ashishrp-aws deleted the feature/agentic-chat branch April 19, 2025 16:36
justinmk3
justinmk3 reviewed Apr 23, 2025
View reviewed changes
packages/core/src/codewhispererChat/tools/executeBash.ts
# Run the actual command in background
# Use '()' to create a subshell which becomes the process group leader
(${this.command}) &
Copy link
Contributor

@justinmk3 justinmk3 Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of inlining the command literally, it would avoid problems with "escaping" to write the command to a file, then execute the file here (bash foo.sh).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@justinmk3 justinmk3 justinmk3 left review comments

@zixlin7 zixlin7 zixlin7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashishrp-aws @justinmk3 @zixlin7